Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(playground): support lan connection #858

Merged
merged 1 commit into from
Jan 26, 2023
Merged

build(playground): support lan connection #858

merged 1 commit into from
Jan 26, 2023

Conversation

doodlewind
Copy link
Member

No description provided.

@codesandbox
Copy link

codesandbox bot commented Jan 26, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Jan 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 26, 2023 at 3:08AM (UTC)
blocksuite-react ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 26, 2023 at 3:08AM (UTC)

@doodlewind doodlewind merged commit 5644d08 into master Jan 26, 2023
@doodlewind doodlewind deleted the 0126/build branch January 26, 2023 03:20
@lawvs
Copy link
Collaborator

lawvs commented Jan 26, 2023

I think there may be potential security risks in having it on by default.

@doodlewind
Copy link
Member Author

I think there may be potential security risks in having it on by default.

This doesn't apply to our online playground, so I guess it should be just fine. This change helps testing collab-editing between different devices under the same Wi-Fi. I'm using this for sharing clipboard between my Mac and Steam Deck 🤪

fundon added a commit to fundon/blocksuite that referenced this pull request Jan 26, 2023
* master:
  refactor: abstract block-specific methods into BlockService (toeverything#857)
  build(playground): support lan connection (toeverything#858)
  refactor(blocks): remove async import in block service (toeverything#856)
  refactor(global,blocks): move `consts.ts` to global (toeverything#855)
  refactor(blocks): move drag handle into default page block (toeverything#854)
  fix(blocks): add readonly restriction in `DefaultSelectionManager` (toeverything#852)
  fix(blocks): forbid user to delete a block inside database block (toeverything#850)
  fix: enable slash menu on playground (toeverything#849)
  fix: update slash menu append behavior (toeverything#848)
  feat: support ctrl+enter shortcut (toeverything#821)
  fix: handle None selection in format quick bar (toeverything#830)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants